Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authn-iam uses unfamiliar AWS STS api #2010

Open
liavyona opened this issue Jan 26, 2021 · 3 comments
Open

authn-iam uses unfamiliar AWS STS api #2010

liavyona opened this issue Jan 26, 2021 · 3 comments

Comments

@liavyona
Copy link
Contributor

Is your feature request related to a problem? Please describe.

According to AWS STS GetCallerIdentity Docs, the request to the service should be a POST https://sts.amazonaws.com with data Action=GetCallerIdentity&Version=2011-06-15 instead of a GET https://sts.amazonaws.com/?Action=GetCallerIdentity&Version=2011-06-15.

A clear and concise description of what the problem is. Ex. I would like to see [...] because [...].
I would like to see a post request (in addition to the get request to keep backwards compatibility) because a post request is the documented and preferred API of sts.

Describe the solution you would like

A fallback of POST request to GET request to AWS STS service.

@orenbm
Copy link
Member

orenbm commented Jan 26, 2021

@shaharglazner you like this issue, eh?

@liavyona liavyona self-assigned this Jan 26, 2021
@izgeri
Copy link
Contributor

izgeri commented Jan 26, 2021

@liavyona is this really an enhancement or a bug?

@liavyona
Copy link
Contributor Author

@izgeri It's an enhancement since the current one still works (even though it uses unknown API of STS) but we cannot rely that this API will stay available for us. Waiting for @InbalZilberman to confirm the fallback and I will push the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants