-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pymde in Scanpy #53
Comments
That would be fantastic! Would Scanpy need to reimplement PyMDE, or could it depend on it? I see that umap-learn is one of its dependencies: https://github.com/theislab/scanpy/blob/master/pyproject.toml#L75 |
Hypothetically it could depend on it (maybe through lazy import and extras...) but the only thing is that scanpy disentangled umap neighbor computation with embedding learning, so somehow using a neighbors graph directly would need to be implemented on the pymde side I think. |
I see. I would be happy to put in the work needed to make this happen. |
This is a super cool package! It would be great to see it directly used in Scanpy
I made an issue there describing a bit about the feature request. It seems pretty straightforward to implement given that you have recipe functions already. I'm not sure how much work it would be to directly use the neighbors graph created by
scanpy.pp.neighbors
(also uses Pynndescent)scverse/scanpy#2154
The text was updated successfully, but these errors were encountered: