Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2 token CORS conflicts with global CORS #445

Open
evert opened this issue Oct 27, 2022 · 0 comments
Open

OAuth2 token CORS conflicts with global CORS #445

evert opened this issue Oct 27, 2022 · 0 comments

Comments

@evert
Copy link
Member

evert commented Oct 27, 2022

The OAuth2 token endpoint has a completely open CORS rules. There's enough security here using other mechanisms that there's no risk here.

Other endpoints by default have no CORS rules, but this can be turned on with the cors.allowOrigin database setting. When this is on, it overrides the OAuth2 cors rules and token gets the same restriction as cors.allowOrigin. Im not sure if this is what we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant