Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When refreshing tokens, require a client_secret _if_ the original token was also created with a client_secret #18

Open
evert opened this issue Mar 13, 2019 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@evert
Copy link
Member

evert commented Mar 13, 2019

Right now it's basically possible to refresh a token with just a clientId.

The OAuth2 spec requires that if the original refresh token was granted via a grant_type that requires basic authentication, then the refresh should also happen with the same method.

This is not a major security issue, but a security issue nonetheless.

@evert evert added the bug Something isn't working label Mar 13, 2019
@evert evert added the good first issue Good for newcomers label Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant