-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up output matchers #545
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. |
Bumped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
There are several matchers defined by Aruba that are very similar to matchers provided by RSpec. For example:
include_output_string
and its aliasesan_output_string_including
andfile_content_including
. These seem similar to theinclude
or perhapsmatch
matchers.include_an_object
. This seems similar toinclude
.Expected Behavior
Aruba should use default RSpec matchers where possible to make its internal code comprehensible and to provide good examples for its users. Also, Aruba should not define generic matchers that may have to be supported beyond their internal use.
Current Behavior
There's a proliferation of matchers that increase the maintenance burden.
Possible Solution
Remove matchers that don't pull their weight.
Context & Motivation
Improving the output of failing steps is hard because there are many custom matchers that all need to be checked.
The text was updated successfully, but these errors were encountered: