Skip to content
This repository has been archived by the owner on Jun 3, 2019. It is now read-only.

Vendor DLL script tag #589

Open
mb8z opened this issue Jul 11, 2018 · 2 comments
Open

Vendor DLL script tag #589

mb8z opened this issue Jul 11, 2018 · 2 comments

Comments

@mb8z
Copy link

mb8z commented Jul 11, 2018

Hey guys!

I have been using the dll webpack plugin without even noticing it running thanks to your boilerplate. That's awesome! 馃帀

Recently I added more packages to the devVendorDLL.include as my builds were getting slower and slower - the app is getting bigger and bigger. My __dev_vendor_dll__.js file is now over 5MB and I've noticed it is not being cached by the browser because of the ?t=${Date.now()} added in the ServerHTML.js file.

My question is - is this a desired behavior? With this in place my browser fetches the file every time I reload the page, and that's a pretty big file for a browser.

@oyeanuj
Copy link
Contributor

oyeanuj commented Jul 28, 2018

@Ancinek What solution did you end up with on this one?

@mb8z
Copy link
Author

mb8z commented Jul 28, 2018

@oyeanuj I鈥檝e just remove the Date.now method from the script tag. I have not noticed any unwanted behavior with this change :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants