-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: Watermark upscaling #397
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey there,
I noticed that these two lines of the watermark filter have been using SizeDown.
https://github.com/cshum/imagor/blob/v1.4.7/vips/filter.go#L51
https://github.com/cshum/imagor/blob/v1.4.7/vips/filter.go#L57
Is there any specific reason to use it instead SizeBoth?
At least from some tests I've done using SizeBoth, it works well there in case the base image is bigger than the max size of the watermark image.
The text was updated successfully, but these errors were encountered: