-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[False-Positive]: Block timestamp
and Dangerous strict equalities
#2425
Comments
got similar issue that I've realized that when the |
Describe the false alarm that Slither raise and how you know it's inaccurate:
Clone
CreateX
before commit pcaversaccio/createx@b60005c and runslither .
with the latest Slither version0.10.2
:These false positives have not been present in the previous versions. So, I guess this is a new regression.
Examples:
Maybe Slither wants to point to the following (non-issues in my context) (link):
_generateSalt()
usesblock.timestamp
under the hood. So maybe the description is simply off:The same for the other warning which has no dangerous equality except if you want to refer to
newContract.code.length == 0
for the codesize check maybe, but in that case the detector message must be improved IMO:Frequency
Very Frequently
Code example to reproduce the issue:
See
CreateX
.Version:
0.10.2
Relevant log output:
No response
The text was updated successfully, but these errors were encountered: