Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a possibility to ignore directories #431

Open
valibali opened this issue Feb 26, 2024 · 4 comments
Open

Adding a possibility to ignore directories #431

valibali opened this issue Feb 26, 2024 · 4 comments

Comments

@valibali
Copy link

valibali commented Feb 26, 2024

Usecase:
Sometimes (especially when using ApplicationSets) in overlay directories (non-Kubernetes manifest-)YAML files are used.
However they are picked up by the YAMLProcessor() as they were Kubernetes manifesters.

So can we either:

  • Ignore an arbitrary path (given in ENVVAR?)?
  • Turn on/off processors?

(deleting them with a pre-processor looked super-ugly)

@Joibel
Copy link
Contributor

Joibel commented Feb 26, 2024

Of the options you've presented I'd prefer the "ignore path" option as a new parameter. Something like lovely_ignore_subpath, taking a space separated list of paths to ignore if they exist.

You could then set this globally as an environment variable if you wanted to.

Would you be interested in contributing this?

@valibali
Copy link
Author

Absolutely!

@Joibel
Copy link
Contributor

Joibel commented Feb 26, 2024

Awesome.

A bit of guidance then:

  • Add the new parameter to pkg/features/features.go
  • Check on the directory in cmd/argocd-lovely-plugin/packageDirectories.go to exclude it.
  • Make sure you make generate before submitting a PR

Ensure you document it in features.go as just being for ignoring 'sub applications' as that's all it'll do.

@valibali
Copy link
Author

#432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants