-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement indirect draw and dispatch. #118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crud89
added
Type: Requirement
An implementation is required before the next release.
Module: Vulkan 🌋
The issue involves the Vulkan backend.
Module: DX12 ❎
The issue involves the DX12 backend.
labels
Jan 11, 2024
I've merged all upstream changes and did some final tests, however I keep this blocked until a new Vulkan SDK ships with a recent DXC binary supporting Shader Model 6.8. |
This was referenced Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Module: DX12 ❎
The issue involves the DX12 backend.
Module: Vulkan 🌋
The issue involves the Vulkan backend.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR adds support for indirect draw (both indexed and non-indexed) and dispatch. Buffers can be marked with
BufferUsage::Indirect
to indicate that they store indirect draw commands. New structures (IndirectBatch
,IndirectIndexedBatch
andIndirectDispatch
) have been added, which are not required but recommended to be used to record indirect commands into indirect draw/dispatch buffers, as the command layout is defined by convention.The Indirect sample shows how to use a compute shader to perform GPU culling to write an indirect buffer, which is then executed on the graphics pipeline to draw simple geometries.
Additionally, some improvements have been made to simplify recording of indirect draw buffers:
Buffers now support counter variables (which allows to useAppendStructuredBuffer
and similar descriptor types).Related issues