Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Feedback! #1

Open
codepathreview opened this issue Oct 31, 2016 · 0 comments
Open

Project Feedback! #1

codepathreview opened this issue Oct 31, 2016 · 0 comments

Comments

@codepathreview
Copy link

馃憤 nice work. A few notes after checking out the code:

  • Good work on a clean UI
  • Good to see you were able to format the timestamp cleanly
  • Good to see you refreshed the timeline after composing a new tweet
  • Nice touch with the character count being displayed while the user composes a tweet
  • Nice to see you used a SwipeRefreshLayout library for easy timeline refreshes
  • Glad to see you made the compose activity into a dialog instead
  • Good job adding detailed view with reply functionality
  • Great job embedding media image in tweet object
  • Good job getting retweet and favorite counts displayed
  • Good job moving compose to FloatingActionButton
  • Good job adding share, delete, retweet and favorite functionality
  • Consider adding [progress bars] (http://guides.codepath.com/android/Handling-ProgressBars#actionbar-progress-bar) to your app whenever a network request goes out
  • The code can use a lot of refactoring. The activities, adapter - they have these huge methods that do everything and its really not readable. A good way will be to break down things in smaller methods. Rest of the code looks clean
  • Consider using Butterknife for view injection

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant