Cross testing in wine (linux host, windows target) fails with nightly rust

[VorpalBlade]

As of rustc 1.76.0-nightly (a96d57bdb 2023-12-15) cross compiling from a Linux host to Windows fails to run some of my tests due to Wine not implementing functionality. This works fine on stable toolchain (1.74).

Is there a way to tell cross to try using a newer wine or something to see if this is fixed?

The errors look like this:

---- add::tests::check_add_normal_script stdout ----
thread 'add::tests::check_add_normal_script' panicked at src/add/tests.rs:301:6:
called `Result::unwrap()` on an `Err` value: Call not implemented. (os error 120)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- add::tests::check_add_smart_script stdout ----
thread 'add::tests::check_add_smart_script' panicked at src/add/tests.rs:325:6:
called `Result::unwrap()` on an `Err` value: Call not implemented. (os error 120)

Unfortunately setting RUST_BACKTRACE=1 doesn't seem to propagate through cross into whatever container it runs the test in.

Here is a CI run showing what happens: https://github.com/VorpalBlade/chezmoi_modify_manager/actions/runs/7231476998/job/19704690937

The same happens locally (where I use podman instead of docker) with: cross +nightly test --config 'build.rustc-wrapper=""' --config 'target.x86_64-unknown-linux-gnu.linker="/usr/bin/gcc"' --target x86_64-pc-windows-gnu

(extra flags are to turn off sccache and mold which cross doesn't seem to like)

[Emilgardis]

You can figure out what change broke this with cargo-bisect-rustc using a script like

#!/usr/bin/env bash
export CROSS_CUSTOM_TOOLCHAIN=1
cross test --target x86_64-pc-windows-gnu

and then run

cargo bisect-rustc --script bisect.sh --target x86_64-pc-windows-gnu --host x86_64-unknown-linux-gnu --end 2023-12-16 --start 2023-10-02

I recently upgraded wine on the main branch images, #1374, altough when I test it with the main images it still fails with the same error

I'll bisect and return with the result

[Emilgardis]

searched nightlies: from nightly-2023-12-13 to nightly-2023-12-15
regressed nightly: nightly-2023-12-14
searched commit range: rust-lang/rust@3340d49...eeff92a
regressed commit: rust-lang/rust@77d1699

bisected with cargo-bisect-rustc v0.6.7

Host triple: x86_64-unknown-linux-gnu
Reproduce with:

cargo bisect-rustc --script bisect.sh --target x86_64-pc-windows-gnu --host x86_64-unknown-linux-gnu --end 2023-12-15 --start 2023-12-13 

#!/usr/bin/env bash
export CROSS_CUSTOM_TOOLCHAIN=1
export CUSTOM_TOOLCHAIN_COMPAT=nightly-x86_64-unknown-linux-gnu
cross test --target x86_64-pc-windows-gnu -v &>> log.txt

[Emilgardis]

I've made a comment on rust-lang/rust#116438 (comment), I suspect a real report should be made though

[Emilgardis]

In rust-lang/rust#116438 (comment) it's pointed out that the issue is with FileAllocationInformation not being handled here https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/ntdll/unix/file.c?ref_type=heads#L4566

I think a report should be done for wine on their bugtracker

[workingjubilee]

Please do file this with Wine.

[VorpalBlade]

Thanks, I will do so when I get some time this weekend.

Thanks a lot for going above and beyond with debugging this. I was just hoping for some general pointers as to where to even begin (since I'm largely unfamiliar with modern Windows).