-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deno server-side-render error #573
Comments
I dealt with the exact same issue today. I fixed it in my use case by simply deleting the window object if the document object is undefined but the window object isn't. if (typeof window !== 'undefined' && typeof document === 'undefined')
delete globalThis.window EDIT: You can set the DENO_FUTURE=1 environment variable to disable the window global in Deno 1.42, and apparently it'll be removed altogether in version 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Error
Any attempt to render goober styles within a deno instance results in
ReferenceError: document is not defined
Environment
I'm the first to admit the problem might be a configuration problem on my end.
Steps to reproduce
deno run example.js
Investigation
Apparently, there is an empty?
window
object in the global namespace within the deno environment. I don't know why, other than deno is aiming towards creating a browser environment on the server (somewhat) for cross-compatible code. However, there is no defaultdocument
-object/DOM.Hence, in
src/core/get-sheet.js
Note: It still works fine in node.js because node does not have a
window
object—and obviously the browser which has both.Suggested Fix
I just don't know if that would break something somewhere, like if
target
has a passed value.Urgency
Low: For my own uses I cloned the repo and hacked a local copy, then bundled the official version for client-side. Doesn't help anyone else, but...
The text was updated successfully, but these errors were encountered: