-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected behaviour when extending components #547
Comments
dashzt
changed the title
Unexpected behaviout when extending components
Unexpected behaviour when extending components
May 18, 2023
@cristianbote, any updates on this? I'm also running into this problem. This is not a trivial bug. If users can't overwrite css properties, then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've created a demo repo to this bug, so it's easier to understand it https://github.com/dashzt/goober-extending-components-bug
Gist of the problem:
We are using preact (10.11.3) and goober (2.1.13) on our project.
We have 2 level inheritance of extended components
Example from demo app:
Then actuall styles applied to the last component (Blue100 in this example) become dependant on the order in which those components are mounted to preact
I've found the order, which I also used in a demo app:
In this case Blue100 and Blue50 have their styles broken
If I take a closer look on Blue100 and Blue50 styles, I see that background: blue class is applied
Which I can see is overriden but background: red, because of the order class selectors are put into
I believe all other combinations of mount order work well
The text was updated successfully, but these errors were encountered: