Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need the cargo dependency? #656

Open
kornelski opened this issue Sep 13, 2023 · 1 comment
Open

Do we need the cargo dependency? #656

kornelski opened this issue Sep 13, 2023 · 1 comment

Comments

@kornelski
Copy link
Member

Should we drop the cargo dependency?

  • It's big and slow to compile.
  • Requires openssl, libgit2.
  • Has high MSRV.
  • Keeping up with Cargo's API changes is a chore, especially that there are also behavior changes.

I think we could rely on shelling out to command-line for cargo. Anybody running cargo crev is obviously going to have the cargo binary. A combination of cargo metadata, crates-index, and cargo-lock could be enough.

@dpc
Copy link
Collaborator

dpc commented Sep 13, 2023

Yeah, it's probably a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants