Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-vet interoperability? #632

Open
kornelski opened this issue Aug 2, 2023 · 1 comment
Open

cargo-vet interoperability? #632

kornelski opened this issue Aug 2, 2023 · 1 comment

Comments

@kornelski
Copy link
Member

There's now a substantial repository of cargo-vet reviews.

The interface of cargo vet is IMHO much more simple and practical.

And it's a waste to have two dependency verification tools, each with incomplete dependency coverage.

So I think we need to consider what is crev's role in relation to cargo-vet. I think having interoperability between the tools would be very useful.

crev to vet

Every crev proof repository could also be a cargo-vet audit repository. We could automatically convert crev proofs into list of vet audits, and put it in the same repo.

The main problem is how to map crev's attributes, like thoroughness and understanding into vet's criteria of safe-to-run and safe-to-deploy. Vet supports custom criteria, so crev could make some up (like trust-medium-rating-positive), but the two built-in ones are essential for vet.

vet to crev

We could have a bot that loads the vet registry and updates a crev proof repo with them.

@kornelski
Copy link
Member Author

For now I went for deducing safe-to-run and safe-to-deploy from a bit of fuzzy logic combining trust + rating + thoroughness + understanding of reviews.

I'm worried that this is not good enough — people's opinions may differ both ways. Some may want more approvals for cargo vet, and some may object that the existing reviews never explicitly stated these criteria, so guessing them is not robust enough.

I think we should just add the criteria field to the reviews explicitly. For the old reviews without them, I'll add config to tune or disable the fuzzy-guessing logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant