Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidental changes during review #479

Open
stefankreutz opened this issue Jun 22, 2022 · 6 comments
Open

Accidental changes during review #479

stefankreutz opened this issue Jun 22, 2022 · 6 comments

Comments

@stefankreutz
Copy link

I'm a bit afraid to do reviews using cargo crev crate goto because I might accidentally change files under ~/.cargo/registry/src and thus corrupt local builds. Wouldn't it be better to create and go to a temporary directory instead?

@dpc
Copy link
Collaborator

dpc commented Jun 22, 2022

Maybe a good idea.

I wouldn't worry too much about it for now though, and IIRC cargo crev verify will warn about any "unceal" packages and cargo crev clean [<package>] will wipe them for you.

@kornelski
Copy link
Member

There's cargo crev open that makes a temp copy.

@dpc
Copy link
Collaborator

dpc commented Aug 17, 2022

I thought open and goto were supposed to be the same, except one just for CLI, the other for IDE.

@kornelski
Copy link
Member

They don't seem to be the same. goto goes to ~/.cargo/registry/src/github.com-1ecc6299db9ec823.

@dpc
Copy link
Collaborator

dpc commented Aug 18, 2022

Would it make sense to unify both of them so they both do a temp copy?

@kornelski
Copy link
Member

Yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants