-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: support <picture> and srcset for dynamic colored-shadow with webp #172
Comments
Hello @xperseguers, Thank you for using our products and for your constructive feedback. Unfortunately, you can't provide a PR because this repo is private so we'll ask you to create a file with the solution and send it to us and we'll integrate it into the next update. If you have another idea on how we can integrate into the product please let us know. Best, |
here you are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm using the following markup to enable serving next-gen format image in webp:
However the dynamic shadow is generated as:
Ideally it should somehow link to the webp version when it supported by the browser.
So something needs to be adapted in your method
initColoredShadows
:Instead of reading the
src
attribute, you should try to read thecurrentSrc
dynamic attribute:Note: I could provide a PR, just unsure at the moment if I thought of every possible case, so up for discussion.
The text was updated successfully, but these errors were encountered: