Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Navbar collapse animation #123

Open
Pioooooo opened this issue Oct 19, 2020 · 5 comments
Open

[Bug] Navbar collapse animation #123

Pioooooo opened this issue Oct 19, 2020 · 5 comments

Comments

@Pioooooo
Copy link

Version

1.0.1

Reproduction link

https://demos.creative-tim.com/argon-design-system/docs/components/navbar.html

Operating System

Windows

Device

PC

Browser & Version

Firefox 81.0.2

Steps to reproduce

opne the page on a small screen like 320x480, click the collapse botton on the navbar to open it and then click on the x botton to close it

What is expected?

there should be a same animation when collapsing it just like expanding

What is actually happening?

the card keeps showing for a while before it suddenly dissappear


Solution

Additional comments

checking the style.css, I found there is a collapsing-out class which should be and is not used when collapsing the navbar. js should be modified or simply use the default bootstrap transition

@rarestoma
Copy link
Contributor

Hi @Pioooooo,

Thank you for working with our products.

Can you please me a short video to see clearly what happens on your device? I tried now and it seems to work fine on our side.

Thank you,
Rares

@Pioooooo
Copy link
Author

I click instantly after opening the panel but it wait for 2sec before it close

2020-10-19 14-54-12.zip

@sajadevo
Copy link

navbar-collapse

Hi @Pioooooo
I think you want to have the same animation on both opening and closing of mobile nav:)
Is its the case?

@rarestoma

Best Regard,
Sajad

@Pioooooo
Copy link
Author

Hi @SajadAhmadNawabi
That's it. Forgive my poor english and manner 0.0

Best Regard,
Pio

@sajadevo
Copy link

@Pioooooo
So there's no animation for closing of mobile nav but, you can add a simple transition for it by your own:)

Thank you,
Sajad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants