Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configurable timeout to CDS Hooks server data request #526

Open
brynrhodes opened this issue Jun 2, 2022 · 2 comments
Open

Add a configurable timeout to CDS Hooks server data request #526

brynrhodes opened this issue Jun 2, 2022 · 2 comments
Labels
cds-hooks Cds-hooks implementation enhancement New feature or request

Comments

@brynrhodes
Copy link
Member

During a CDS Hooks call, if the service makes a call back to the FHIR Server, that call should have a configurable timeout that if it takes longer than that timeout to execute, short-circuits the service call with an error that says "source system is taking too long to respond and guidance cannot be provided as a result"

@brynrhodes brynrhodes added the enhancement New feature or request label Jun 2, 2022
@JPercival
Copy link
Contributor

Duplicates #472, closing that one in favor of this one.

@JPercival
Copy link
Contributor

Here's where the callback client is set up:

https://github.com/DBCG/cqf-ruler/blob/master/plugin/cds-hooks/src/main/java/org/opencds/cqf/ruler/cdshooks/evaluation/EvaluationContext.java#L168

What we need to do is add some properties to the cds-hooks config class here:

https://github.com/DBCG/cqf-ruler/blob/master/plugin/cds-hooks/src/main/java/org/opencds/cqf/ruler/cdshooks/CdsHooksProperties.java

And then pass that configuration down through the evaluation context so that the timeout can be set.

@c-schuler c-schuler added the cds-hooks Cds-hooks implementation label Jun 23, 2022
@JPercival JPercival added 1 and removed 1 labels Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cds-hooks Cds-hooks implementation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants