-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ambiguous Tag in the output file when ran cell optimizations #3423
Comments
I don't think this is a bug.
could be changed to
|
Thank you for your reply.
As I presented before, CP2K already has the
Why not use it to denote non-convergence as well? like,
This would provide consistency in the tagging system, making it easier to identify both the convergence and non-convergence states at a glance and easier for programming scripts. |
It is not a bug, just a typo in the output. The word RMS is missing |
I will revise that output to avoid any ambiguity. |
Thank you very much. |
* Tag and homogenize optimizer output * Align optimizer output with MD output * Fix ambiguous optimizer tags (cp2k#3423) * Homogenize optimizer printout
* Tag and homogenize optimizer output * Align optimizer output with MD output * Fix ambiguous optimizer tags (#3423) * Homogenize optimizer printout
* Tag and homogenize optimizer output * Align optimizer output with MD output * Fix ambiguous optimizer tags (cp2k#3423) * Homogenize optimizer printout
Dear CP2K developers,
I found an ambiguous tag in the output file (
.out
) when I ran cell optimizations. The details are presented as follows.In the "Convergence check" section, when neither 'Max. gradient' nor 'RMS gradient' meets the convergence criteria, their tags are both displayed as "Conv. for gradients = No". For ease of reference, I have marked the position of the tags with arrows.
The same tags of Conv. for gradients can lead to confusion.
Once the 'RMS gradient' meets the convergence criteria, however, it displays as "Conv. in RMS gradients". Please see below.
As shown above, the CP2K program already includes the tag "Conv. in RMS gradients", which indicates that the RMS gradients have converged, contrasting the earlier ambiguous label "Conv. for gradients".
It is recommended that developers address the mentioned bug so that when 'RMS gradient' does not meet the convergence criteria, it displays as "Conv. in RMS gradients = No".
Thanks a lot.
Huan
The text was updated successfully, but these errors were encountered: