-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for automatic resizing if volume size was expanded directly on Hetzner #20
Comments
This would probably work, but I wonder if this isn't piling too many responsibilities on the driver. I feel like this might be crossing a conceptual line because it would be a non-trivial change to existing data (as opposed to mkfs/chown on a brand new volume), so the danger of data loss becomes more "real". But to be honest I haven't used this tool myself in years, so I my opinion might not be that relevant 🙈 |
Yeah. This would be something to only do automatically in some cases in my opinion. This should be opt in on a volume to volume Basis because of the reason you stated: data loss. For now I think its best if I gather some ideas here and come up with a concept. I have resized some Volumes manually myself so it is not that big of a deal, but having this working automatically would be awesome nonetheless. |
Thinking about it, another idea to consider would be to have some Kind of companion service to the plugin or even integrated that exposes an API endpoint that can do the resizing for a particular volume. Then users can decide on their own when and how to resize and even via some kind of automation if they want to. But again, just an idea. Lets first get the chown PR tested and merged, then we can get fancier. |
A stopgap solution until a proper workaround has been found for expanding the volumes could be to add an additional step to mounting where we could check the size of the volume when we created it vs what it is right now.
Then, if it differs, we could run resize2fs before mounting it to the actual container.
What do you think?
The text was updated successfully, but these errors were encountered: