-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICS4: sendPacket should add a check to ensure client is not frozen #555
Labels
implementation
Tracking an external implementation of the spec.
tao
Transport, authentication, & ordering layer.
Comments
Yes, both changes make sense to me. |
As a part of this issue, IsFrozen checks in light clients may be removed as it should be checked in 02, 03, and 04 before doing any verification, updates, or misbehaviour processing |
mpoke
changed the title
04-channel sendPacket should add a check to ensure client is not frozen
ICS4: sendPacket should add a check to ensure client is not frozen
Mar 17, 2022
mpoke
added
tao
Transport, authentication, & ordering layer.
implementation
Tracking an external implementation of the spec.
labels
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
implementation
Tracking an external implementation of the spec.
tao
Transport, authentication, & ordering layer.
Currently the spec assumes that all the client Verify functions ensure that the client is not frozen. The problem is that the
sendPacket
function does not call any verify functions. This allows packets to be sent with frozen clients. In the token transfer case, if the packet is never received, the tokens sent are lost since a timeout can never be processed.We check for this situation in the code. Given that the spec makes a reference to client freezing in
02-client
, I think it is ok to add this check into sendPacket.I also would like this to check to match the proposed change in
ibc-go
which would prevent users from sending funds on expired clientsThe text was updated successfully, but these errors were encountered: