Fix facility n+1 #2089
Open
Fix facility n+1 #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithviknishad
requested review from
Ashesh3,
vigneshhari,
khavinshankar and
sainak
rithviknishad
approved these changes
Apr 18, 2024
sainak
requested changes
Apr 18, 2024
| "district", | ||
| "state", | ||
| ) | ||
| .prefetch_related("patientregistration_set", "bed_set") |
There was a problem hiding this comment.
instead of prefetch try annotating the count using subquery, and in the serializer check if the annotated attribute is present else fallback to filtering
| return PatientRegistration.objects.filter( | ||
| facility=facility, is_active=True | ||
| ).count() | ||
| return facility.patientregistration_set.count() |
There was a problem hiding this comment.
Suggested change
| return facility.patientregistration_set.count() | |
| if getattr(self, "annotated_count...": | |
| return self.annotated_count... | |
| return facility.patientregistration_set.filter(is_active=True).count() |
|
@sainak have resolved your comments pls take a look |
Ashesh3
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
using prefetch related for both the fields (PatientRegistration and Bed)
Associated Issue
fixes: #1920
Architecture changes
Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins