Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scss variable $header-min-height not respected (migration to v5) #750

Closed
meriturva opened this issue Apr 22, 2024 · 3 comments
Closed

Scss variable $header-min-height not respected (migration to v5) #750

meriturva opened this issue Apr 22, 2024 · 3 comments

Comments

@meriturva
Copy link

See here:

// min-height: var(--#{$prefix}header-min-height);

any reason for that?
Thanks.

@meriturva
Copy link
Author

Any news @mrholek ? I didn't see any changes related to that and other scss issues on last week's release (v5.0.1).
So thanks.

@mrholek
Copy link
Member

mrholek commented May 17, 2024

We removed $header-min-height and $sidebar-brand-height because the main purpose was to have the height of template elements the same. As it is more relevant to templates, not library, we decided to move those styles here - https://github.com/coreui/coreui-free-bootstrap-admin-template/blob/main/src/scss/_theme.scss

@meriturva
Copy link
Author

Thanks, customization created on my theme files!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants