Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free shipping option won't get applied #2308

Open
valentin- opened this issue Jun 5, 2023 · 4 comments
Open

Free shipping option won't get applied #2308

valentin- opened this issue Jun 5, 2023 · 4 comments

Comments

@valentin-
Copy link
Contributor

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

Hi, I'm not sure if it's related to this ticket: #2178

Currently there are 2 carrier options available when the total price is 0.

image

I want to select Gratisversand, but Selbstabholung is selected on the summary page.

image

It looks like the check fails at:

if (!$this->carrierValidator->isCarrierValid($cart->getCarrier(), $cart, $address)) {

This rule is applied for the carrier Gratisversand:

image

Thanks!

@dpfaffenbauer
Copy link
Member

@valentin- is this still a issue?

@valentin-
Copy link
Contributor Author

Hi @dpfaffenbauer I've udpated Coreshop from 3.0.6 to 3.2.0 - the error still occurs.

I also ran into a new issue. When selecting the default payment option (paid) a SQL error occurs. I executed the migrations, and the fields are present - but probably mismatch?

image

image

@dpfaffenbauer
Copy link
Member

@valentin- that is a problem with a dependency of CoreShop, see #865

Re Main Topic of this issue, can you describe again what the Problem is? I cannot really follow your it

@valentin-
Copy link
Contributor Author

@dpfaffenbauer there are 2 shipping rules available:

When I pick Gratisversand the summary shows Selbstabholung as selected delivery rule.
I think Selbstabholung is applied as the validation for Gratisversand fails in the isCarrierValid() check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants