From 7ae2fa8e3ef832c8ca7fa1301a15791f696a7a7f Mon Sep 17 00:00:00 2001 From: CoreShop Date: Mon, 1 May 2023 02:30:09 +0000 Subject: [PATCH] [CS] Refactor --- src/CoreShop/Bundle/OrderBundle/Manager/CartManager.php | 2 +- .../DependencyInjection/CoreShopStorageListExtension.php | 1 - .../Bundle/StorageListBundle/EventListener/CacheListener.php | 4 ++-- .../Order/Cart/Rule/Action/CartItemActionProcessor.php | 3 +-- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/CoreShop/Bundle/OrderBundle/Manager/CartManager.php b/src/CoreShop/Bundle/OrderBundle/Manager/CartManager.php index ba46cf6acc..ef3089f35e 100644 --- a/src/CoreShop/Bundle/OrderBundle/Manager/CartManager.php +++ b/src/CoreShop/Bundle/OrderBundle/Manager/CartManager.php @@ -80,7 +80,7 @@ public function persistCart(OrderInterface $cart): void ); //$item->setPath($cart->getFullPath()); $item->setPublished(true); - $item->setKey((string)((int)$index + 1)); + $item->setKey((string) ((int) $index + 1)); $item->save(); } diff --git a/src/CoreShop/Bundle/StorageListBundle/DependencyInjection/CoreShopStorageListExtension.php b/src/CoreShop/Bundle/StorageListBundle/DependencyInjection/CoreShopStorageListExtension.php index 084faffc10..58ac105021 100644 --- a/src/CoreShop/Bundle/StorageListBundle/DependencyInjection/CoreShopStorageListExtension.php +++ b/src/CoreShop/Bundle/StorageListBundle/DependencyInjection/CoreShopStorageListExtension.php @@ -106,7 +106,6 @@ public function load(array $configs, ContainerBuilder $container): void $sessionSubscriber->addTag('kernel.event_subscriber'); $container->setDefinition('coreshop.storage_list.session_subscriber.' . $name, $sessionSubscriber); - } $cacheSubscriber = new Definition(CacheListener::class, [ diff --git a/src/CoreShop/Bundle/StorageListBundle/EventListener/CacheListener.php b/src/CoreShop/Bundle/StorageListBundle/EventListener/CacheListener.php index 95548aaf16..60c150bf37 100644 --- a/src/CoreShop/Bundle/StorageListBundle/EventListener/CacheListener.php +++ b/src/CoreShop/Bundle/StorageListBundle/EventListener/CacheListener.php @@ -75,10 +75,10 @@ public function onKernelResponse(ResponseEvent $event): void continue; } - Cache::addIgnoredTagOnSave('object_'.$item->getId()); + Cache::addIgnoredTagOnSave('object_' . $item->getId()); } - Cache::addIgnoredTagOnSave('object_'.$list->getId()); + Cache::addIgnoredTagOnSave('object_' . $list->getId()); } } } diff --git a/src/CoreShop/Component/Order/Cart/Rule/Action/CartItemActionProcessor.php b/src/CoreShop/Component/Order/Cart/Rule/Action/CartItemActionProcessor.php index e92d5072de..2e1e21654f 100644 --- a/src/CoreShop/Component/Order/Cart/Rule/Action/CartItemActionProcessor.php +++ b/src/CoreShop/Component/Order/Cart/Rule/Action/CartItemActionProcessor.php @@ -94,8 +94,7 @@ public function applyRule(OrderInterface $cart, array $configuration, PriceRuleI if (!$result) { $item->removePriceRule($priceRuleItem); - } - else if (!$existingPriceRule) { + } elseif (!$existingPriceRule) { $item->addPriceRule($priceRuleItem); }