Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump required Go version to 1.13 #391

Open
invidian opened this issue Jan 10, 2022 · 2 comments · May be fixed by #390
Open

Bump required Go version to 1.13 #391

invidian opened this issue Jan 10, 2022 · 2 comments · May be fixed by #390

Comments

@invidian
Copy link

1.12 is now EOL for almost 2 years: https://endoflife.date/go.

As a reference, supported Ubuntu versions use either 1.10 or 1.13:
https://packages.ubuntu.com/search?keywords=golang-go

So I think this bump is reasonable.

This is done to get access to stdlib methods like errors.Is and
formatting statement %w, which is de facto standard for handling errors
nowadays.
invidian added a commit to kinvolk/go-systemd that referenced this issue Jan 10, 2022
@invidian
Bump minimum Go version to 1.13
4da2df9 
1.12 is now EOL for almost 2 years: https://endoflife.date/go.

As a reference, supported Ubuntu versions use either 1.10 or 1.13:
https://packages.ubuntu.com/search?keywords=golang-go

So I think this bump is reasonable.

This is done to get access to stdlib methods like errors.Is and
formatting statement %w, which is de facto standard for handling errors
nowadays.

Closes coreos#391

Signed-off-by: Mateusz Gozdek <[email protected]>
@invidian invidian linked a pull request Jan 10, 2022 that will close this issue
Open
@lucab
Copy link
Contributor

lucab commented Jan 10, 2022

I think this effectively means moving the module to v23, i.e. a major breaking change.
I'm not fully against it, but it is going to introduce a huge churn across all consumers.

@invidian
Copy link
Author

Is there some roadmap for v23 available? What should go in and what not? Or is there some dev branch for v23 available to submit PRs against?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

login1: add NewWithConnection and RebootWithContext methods kinvolk/go-systemd
2 participants
@lucab @invidian