Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is streamy not released on Rubygems #65

Open
ChrisBr opened this issue Apr 9, 2019 · 3 comments
Open

Why is streamy not released on Rubygems #65

ChrisBr opened this issue Apr 9, 2019 · 3 comments
Labels

Comments

@ChrisBr
Copy link
Contributor

ChrisBr commented Apr 9, 2019

I'm just wondering why Streamy is not released as a gem on Rubygems?

Screen Shot 2019-04-09 at 16 41 31

  • We already use streamy since a while in production
  • There is already a gemspec etc
  • Cookpad is committed to support open source

I don't see any strong reason why we don't release it...

@balvig
Copy link
Contributor

balvig commented Apr 10, 2019

Ah, to give some context: The main reason for this gem to exist, is to capture our conventions around event broadcasting/consumption across projects.

To that end a gem is quite convenient, and having it in a public repository avoids a lots of hassle around permissions etc.

That of course also has the "side effect" of making it open source, and since there is nothing secret or proprietary in here, and people stumbling across it might find something of use, I'm personally happy to have it as such.

Beyond that, to be honest I don't know how useful it is for public consumption just yet (it is basically a very thin layer on top of existing gems) but I also don't have a particularly strong opinion against putting it on RubyGems?

The main reason for not having done so however, is that while the gem was (is?) under heavy development, it's one less step to have to do when making changes.

Since the apps using the gem all point to GitHub, it goes something like:

$ ~/streamy [master] » git push
$ ~/global-web [master] » bundle update streamy

vs

$ ~/streamy [master] » git push
$ ~/streamy [master] » sed -i '' 's/0.2.0/0.3.0/g' lib/streamy/version.rb 
$ ~/streamy [master] » git commit -am "bump version"
$ ~/streamy [master] » bundle exec rake release # releaser needs to be owner of gem?
$ ~/global-web [master] » bundle update streamy

So yeh, I guess to summarize, I think it's perfectly fine to have it on RubyGems but:

  • I don't know that it's useful beyond our own needs just yet (and also likely to rapidly change).
  • People who do find it can still use it the same way we do.
  • I imagine it would make using it internally slightly more fiddly, perhaps unnecessarily?
  • If however f.ex you think it might be fun/interesting to take it towards something a bit more generally useable, and pushing it to RubyGems better enables that, then 🚀 !

@ChrisBr
Copy link
Contributor Author

ChrisBr commented Apr 10, 2019

@balvig thanks for you answer! My thoughts about your bullet points 😄

I don't know that it's useful beyond our own needs just yet (and also likely to rapidly change).

I guess we only can find that out when we release it to see how many people will download and/or approach us 🤔

People who do find it can still use it the same way we do.

Generally speaking, most people (including me/coookpad web chapter) hesitate to use a gem which is not released on GitHub I would assume.

I imagine it would make using it internally slightly more fiddly, perhaps unnecessarily?

We can still point internally to master. We don't need to use a released version, do we?

@balvig
Copy link
Contributor

balvig commented Apr 11, 2019

most people hesitate to use a gem which is not released

That's probably true, but I also suspect people won't find it unless it's "promoted" (ie blog posts etc).

That's where I wonder if at the current stage it's even useful beyond our own needs. A good "test" might be to imagine writing a blog post about it, ie what would the "sales pitch" look like 😉.

We can still point internally to master. We don't need to use a released version, do we?

We don't!

But then I do wonder if since we're not "dogfooding" we will even remember to release versions etc 🤔.

So in any case, again while I guess I don't personally expect much difference whether it's pushed to RubyGems or not, if you feel strongly about it then 👍 as far as I'm concerned!

@balvig balvig removed their assignment Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants