Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should there be (a11y) commit type? How do you address accessibility UI related changes? #577

Open
webmatrixxxl opened this issue Mar 15, 2024 · 1 comment

Comments

@webmatrixxxl
Copy link

webmatrixxxl commented Mar 15, 2024

Hello!

In the Front-End world recently because of the European Accessibility Act, we have been required (for good) to implement a lot of accessibility across components and pages.

And I started wondering how we should address accessibility in the commit messages.

a11y(checkout): add alt text to card types in checkout

or

accessibility(checkout): add alt text to card types in checkout

or we can stick to

feat(checkout): add alt text to card types in checkout

or maybe

chore(checkout): add alt text to card types in checkout

Personally, I kind of prefer the first one. I'm thinking about the feat and fix in the scope of functionality and accessibility is on top of that.

I have seen this in another project as well: link

What do you think?

@henrikhelmers
Copy link

On the one hand, accessibility should be part of code quality (be it by adding alt text or correctly implementing design), which would make "chore" correct.

On the other hand it would be valuable to be able to point at commits related to accessibility to document effort in that area. I also belive that as the amount of awareness (and legislation) increase, the amount of commits directly related to accessibility will as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants