-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Quota map is not thread-safe (concurrent map read and map write error) #1394
Comments
Ezetowers
changed the title
Project Quota map is not thread-safe
Project Quota map is not thread-safe (concurrent map read and map write error)
Oct 17, 2022
Thanks! I was trying to see if there was any other thing we should think about. @Ezetowers if you'd like to add a lock to the Control object, and lock the couple of public functions, I would appreciate it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
While using cri-o as container runtime, a race condition was found by the Golang compiler and the service crashed. It seems to be the error is associated with the lack of locking when the quota map is accessed in the projectquota.go file in this library.
Since this is a race condition, I am not able to create a set of steps to reproduce this issue, but if you think this problem belongs to this lib I can create a PR adding proper locking to the quota maps in the projectquota.go file
Kind Regards
Ezequiel
The text was updated successfully, but these errors were encountered: