Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light mode for Link #7215

Closed
Tracked by #4914
deboer-tim opened this issue May 14, 2024 · 0 comments · Fixed by #7216
Closed
Tracked by #4914

Light mode for Link #7215

deboer-tim opened this issue May 14, 2024 · 0 comments · Fixed by #7216
Assignees
@deboer-tim
Labels
kind/enhancement ✨ Issue for requesting an improvement status/need-triage

Comments

@deboer-tim
Copy link
Collaborator

Is your enhancement related to a problem? Please describe

The Link component has hard-coded colors and doesn't support light mode.

Describe the solution you'd like

Extract current colors to the registry and add light mode colors.

Describe alternatives you've considered

No response

Additional context

No response
@deboer-tim deboer-tim added the kind/enhancement ✨ Issue for requesting an improvement label May 14, 2024
@deboer-tim deboer-tim mentioned this issue May 14, 2024
Open
31 tasks
deboer-tim added a commit to deboer-tim/desktop that referenced this issue May 14, 2024
@deboer-tim
chore: link light mode
644a4d4 
Adds light mode support to Link component, using color defined in design for
containers#7149.

Fixes containers#7215.

Signed-off-by: Tim deBoer <[email protected]>
@deboer-tim deboer-tim mentioned this issue May 14, 2024
Merged
1 task
@deboer-tim deboer-tim self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deboer-tim deboer-tim

Labels
kind/enhancement ✨ Issue for requesting an improvement status/need-triage
Projects
Podman Desktop Planning
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: link light mode deboer-tim/desktop
2 participants
@deboer-tim @podman-desktop-bot