Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share code for bulk deletion #5745

Open
deboer-tim opened this issue Jan 29, 2024 · 1 comment · May be fixed by #5847
Open

Share code for bulk deletion #5745

deboer-tim opened this issue Jan 29, 2024 · 1 comment · May be fixed by #5847
Labels
area/dashboard 📊 Concern the dashboard from Container Desktop kind/technical-debt 🔧

Comments

@deboer-tim
Copy link
Collaborator

Is your enhancement related to a problem? Please describe

From discussion in #5717: there's lot of similar code for bulk deletion on every page - is it possible to share code?

Describe the solution you'd like

At a minimum, utility function(s) for marking object status or handling the promises. Would be cool if there's a way to have some kind of 'bulk action helper' that would help with button state and act on all the objects.

Describe alternatives you've considered

No response

Additional context

No response
@deboer-tim deboer-tim added kind/enhancement ✨ Issue for requesting an improvement kind/technical-debt 🔧 labels Jan 29, 2024
@benoitf benoitf added area/dashboard 📊 Concern the dashboard from Container Desktop and removed kind/enhancement ✨ Issue for requesting an improvement status/need-triage labels Jan 31, 2024
@trmendes trmendes linked a pull request Feb 5, 2024 that will close this issue
Draft
@trmendes
Copy link
Contributor

trmendes commented Feb 5, 2024 •
edited

@deboer-tim I would like to work on sharing the code.

I'm creating a draft PR as 1st attempt so, I can do the right changes and make a better code to share.

Would you mind reviewing it?

I would love to get some feedback and new ideas.

I wanted to give the common function the deletion callback as a parameter, but I'm not sure what would be the best way to handle function with different signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dashboard 📊 Concern the dashboard from Container Desktop kind/technical-debt 🔧
Projects
Podman Desktop Planning
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: share code for bulk deletion trmendes/podman-desktop
4 participants
@benoitf @trmendes @deboer-tim @podman-desktop-bot