Micro-optimization: Use storage.Store.ImagesByDigest for digest references

[mtrmac]

Runtime.lookupImageInDigestsAndRepoTags calls, in

common/libimage/runtime.go

Line 426 in 18c4568

allImages, err := r.ListImages(context.Background(), nil, nil)

, effectively storage.Store.Images, getting a copy of all images.

On the

common/libimage/runtime.go

Line 441 in 18c4568

if isDigested {

path, allImages is manually filtered to only those (the first one) that actually match that digest in storage.Image.Digests.

It seems to me that that code path could call storage.Store.ImagesByDigest, and the full allImages collection could only happen later, to implement the inRepoTags search.

That would save a bit of memory and CPU time when copying image objects from the c/storage primary records into a return value, and the like — OTOH it’s all on a “fallback heuristics” path, so it might well not be worth worrying about.