Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package list in the admin UI should include pip packages #815

Open
nkaretnikov opened this issue Apr 26, 2024 · 0 comments
Open

Package list in the admin UI should include pip packages #815

nkaretnikov opened this issue Apr 26, 2024 · 0 comments
Labels
area: dependencies 📦 Issues related to conda-store dependencies area: user experience 👩🏻‍💻 Items impacting the end-user experience type: enhancement 💅🏼

Comments

@nkaretnikov
Copy link
Contributor

Context

Go to http://localhost:8080/conda-store/admin/build/<build_id>/. No pip packages are listed in "Conda Packages". Example spec:

channels:
- conda-forge
dependencies:
- python ==3.9
- pip:
  - flask
description: ''
name: test
prefix: null
variables: null

This is because conda-store-server/conda_store_server/server/templates/build.html only uses build.package_builds which doesn't contain pip packages:

{% if build.status.value in ['COMPLETED'] %}
...
        <h3 class="card-title">Conda Packages
            <span class="badge badge-light">{{ build.package_builds | length }}</span>
...
{% for package_build in build.package_builds %}
...
{% endif %}

Once pip packages are included, the list should be renamed to just "Packages".

Value and/or benefit

Admin UI is consistent with specification/lists all packages.

Anything else?

No response

@nkaretnikov nkaretnikov added needs: triaging 🚦 Someone needs to have a look at this issue and triage type: enhancement 💅🏼 area: dependencies 📦 Issues related to conda-store dependencies area: user experience 👩🏻‍💻 Items impacting the end-user experience and removed needs: triaging 🚦 Someone needs to have a look at this issue and triage labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 Issues related to conda-store dependencies area: user experience 👩🏻‍💻 Items impacting the end-user experience type: enhancement 💅🏼
Projects
Status: New 🚦
Development

No branches or pull requests

1 participant