-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.2.0 of sphinxcontrib-video initial conda-forge package added #26407
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For sphinxcontrib-video:
For sphinxcontrib-video:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/sphinxcontrib-video:
For recipes/sphinxcontrib-video:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/sphinxcontrib-video:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python ready for review! further maintainers are welcome :) |
conda_build_config.yaml
Outdated
- 11.0 # [osx] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you want to be changing things outside of recipes
here? Wouldn't it be better to do this as its own PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Let's just revert this and ignore the linter for now. Whoever made this change in conda-smithy probably just forgot to update it here. I'm out of the loop in this change so I'd rather not touch it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/sphinxcontrib-video:
|
I copied the version from branch main over the old. This seems not to have a newline ending, wanted? |
Thx, @ocefpaf I've just seen that on the new modules page https://anaconda.org/conda-forge/sphinxcontrib-video The description I provided is missing. Was there a syntax change? |
I don't know how that is populated. To be honest, I don't even look at the anaconda platform for package info, only the feedstock. I'd ask in the element conda-forge channel and hope that someone from Anaconda answers. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).