Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.0 of sphinxcontrib-video initial conda-forge package added #26407

Merged
merged 7 commits into from
May 21, 2024

Conversation

ReimarBauer
Copy link
Contributor

@ReimarBauer ReimarBauer commented May 19, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (sphinxcontrib-video) and found some lint.

Here's what I've got...

For sphinxcontrib-video:

  • The home item is expected in the about section.
  • Please do not delete the example recipe found in recipes/example/meta.yaml.

For sphinxcontrib-video:

  • In your conda_build_config.yaml, please change the name of MACOSX_DEPLOYMENT_TARGET, to c_stdlib_version!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sphinxcontrib-video) and found some lint.

Here's what I've got...

For recipes/sphinxcontrib-video:

  • The home item is expected in the about section.

For recipes/sphinxcontrib-video:

  • In your conda_build_config.yaml, please change the name of MACOSX_DEPLOYMENT_TARGET, to c_stdlib_version!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sphinxcontrib-video) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/sphinxcontrib-video:

  • In your conda_build_config.yaml, please change the name of MACOSX_DEPLOYMENT_TARGET, to c_stdlib_version!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sphinxcontrib-video) and found it was in an excellent condition.

@ReimarBauer
Copy link
Contributor Author

@conda-forge/help-python ready for review!

further maintainers are welcome :)

@ReimarBauer ReimarBauer changed the title v0.2.0 of sphinxcontrib-video initial conda-forge package v0.2.0 of sphinxcontrib-video initial conda-forge package added May 19, 2024
conda_build_config.yaml Outdated Show resolved Hide resolved
Comment on lines 1 to 2
- 11.0 # [osx]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to be changing things outside of recipes here? Wouldn't it be better to do this as its own PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Let's just revert this and ignore the linter for now. Whoever made this change in conda-smithy probably just forgot to update it here. I'm out of the loop in this change so I'd rather not touch it for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhochy, it looks like you were involved in the PR that added this file:
#24549
Any insight?

In any case, nothing that needs to be discussed here...

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sphinxcontrib-video) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/sphinxcontrib-video:

  • In your conda_build_config.yaml, please change the name of MACOSX_DEPLOYMENT_TARGET, to c_stdlib_version!

@ReimarBauer
Copy link
Contributor Author

@ocefpaf @xylar I have undone that change.

@ReimarBauer
Copy link
Contributor Author

I copied the version from branch main over the old. This seems not to have a newline ending, wanted?

@ocefpaf ocefpaf merged commit f200d3b into conda-forge:main May 21, 2024
5 checks passed
@ReimarBauer
Copy link
Contributor Author

Thx,

@ocefpaf I've just seen that on the new modules page https://anaconda.org/conda-forge/sphinxcontrib-video

The description I provided is missing. Was there a syntax change?

@ReimarBauer ReimarBauer deleted the sphinxcontrib-video branch May 21, 2024 05:18
@ocefpaf
Copy link
Member

ocefpaf commented May 21, 2024

The description I provided is missing. Was there a syntax change?

I don't know how that is populated. To be honest, I don't even look at the anaconda platform for package info, only the feedstock. I'd ask in the element conda-forge channel and hope that someone from Anaconda answers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants