Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding geouned #26385

Merged
merged 22 commits into from
May 17, 2024
Merged

Adding geouned #26385

merged 22 commits into from
May 17, 2024

Conversation

shimwell
Copy link
Contributor

This PR adds geouned to conda forge. It would be great to get geouned onto conda forge as it uses freecad as its main dependency and therefore a conda-forge package would make installing geouned easier. We might get a few other geouned devs volunteering as maintainers for this recipe. Link to geouned feature request

Many thanks for considering this package

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/geouned) and found it was in an excellent condition.

recipes/geouned/meta.yaml Outdated Show resolved Hide resolved
@shimwell
Copy link
Contributor Author

The windows build appears to be failing with an error message I've not Seend before

Cmd.exe exited with code '1'.

This is a noarch package but this should build on windows so I shall look into this failure.

recipes/geouned/meta.yaml Outdated Show resolved Hide resolved
@shimwell
Copy link
Contributor Author

ok I think that I understand what is going on. I have a section in the package pyproject.toml which makes a command line tool / script

[project.scripts]
geouned_cadtocsg = "geouned.GEOUNED.scripts.geouned_cadtocsg:main"

However according to this issue the noarch build results in an exe file of the script file if it has no extension.

conda/conda-build#4385

It looks to me that the CI does not like the .exe extension.

recipes/geouned/meta.yaml Outdated Show resolved Hide resolved
recipes/geouned/meta.yaml Outdated Show resolved Hide resolved
@shimwell
Copy link
Contributor Author

sorry to ask for help here, I've tried a few things but can't get the windows build to work

Here is the CI error

Successfully built geouned
Installing collected packages: geouned

Successfully installed geouned-0.0.0
Removed build tracker: 'C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pip-build-tracker-hc0tv75i'

Resource usage statistics from building geouned:
   Process count: 3
   CPU time: Sys=0:00:00.4, User=0:00:01.0
   Memory: 62.0M
   Disk usage: 15.5M
   Time elapsed: 0:00:06.1


Packaging geouned
Packaging geouned-1.1.0-pyhd8ed1ab_0
number of files: 67
   INFO: sysroot: 'C:/Windows/' files: '['winhlp32.exe', 'win.ini', 'twain_32/wiatwain.ds', 'twain_32.dll']'
   INFO (geouned,Scripts/geouned_cadtocsg.exe): Needed DSO C:/Windows/System32/KERNEL32.dll found in $SYSROOT
   INFO (geouned,Scripts/geouned_cadtocsg.exe): Needed DSO C:/Windows/System32/SHLWAPI.dll found in $SYSROOT
   INFO (geouned): Interpreted package 'geouned' is interpreted by 'python'
[noarch_python] Noarch package contains binary script: geouned_cadtocsg.exe
##[error]Cmd.exe exited with code '1'.
Finishing: Build recipes

I think it is related to this bug report

Any chance @conda-forge/help-python has any pointers that could help with this error message

many thanks

recipes/geouned/meta.yaml Outdated Show resolved Hide resolved
@shimwell
Copy link
Contributor Author

🥳 all the CI is passing with the new greyskull based meta.yml many thanks @ocefpaf

This is ready for review if anyone has time.

@ocefpaf ocefpaf merged commit b8d691b into conda-forge:main May 17, 2024
5 checks passed
@shimwell
Copy link
Contributor Author

Looking for the geouned feedstock and I see the repo has been made here.

https://github.com/conda-forge/geouned-feedstock

Currently the repo empty so I wondering if something failed in the production pipeline. I'm looking into conda forge statue messages

@ocefpaf
Copy link
Member

ocefpaf commented May 20, 2024

I believe we had an expired token. The service that builds the feedstock should be back up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants