Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend wrap functionality #5696

Closed
2 tasks done
liady opened this issue May 16, 2024 · 0 comments · Fixed by #5758
Closed
2 tasks done

Extend wrap functionality #5696

liady opened this issue May 16, 2024 · 0 comments · Fixed by #5758
Assignees
@liady

Comments

@liady
Copy link
Contributor

liady commented May 16, 2024 •
edited

We need the new "Wrap..." component picker to have these fuctionalities:

  • Wrap in non-elements (conditionals, etc)
  • Wrap multiple elements
@liady liady mentioned this issue May 16, 2024
Closed
@liady liady self-assigned this May 16, 2024
@liady liady changed the title Expand wrap functionality Extend wrap functionality May 16, 2024
@liady liady mentioned this issue May 22, 2024
Merged
2 tasks
liady added a commit that referenced this issue May 23, 2024
@liady
Wrap in List (#5722)
17a8370 
**Problem:**
We cannot currently wrap with a List

**Fix:**
This PR fixes wrapping a single element with a list.

**Details:**
1. Adding a List as an option for "Wrap..."
2. Adjust the code so that wrapping in a map (which is currently two `INSERT`s in disguise) will actually `REPLACE` the map contents
3. NOTE - this PR supports a single element wrapping.

For multiple element wrapping see #5696

<video src="https://github.com/concrete-utopia/utopia/assets/7003853/0dfc0062-8c9a-4e19-9bfc-5a138f0a2df3"></video>

- [X] I opened a hydrogen project and it loaded
- [X] I could navigate to various routes in Preview mode

Fixes #5419
@Rheeseyb Rheeseyb mentioned this issue May 24, 2024
Closed
@liady liady mentioned this issue May 27, 2024
Merged
2 tasks
liady added a commit that referenced this issue May 28, 2024
@liady
Feat: Wrap multiple elements using the new picker (#5758)
e29bcac 
**Problem:**
Our current picker does not support multiple selections, we need this functionality for wrapping multiple elements

**Fix:**
Make the new picker accept multiple selections.

Important note: this PR adds the functionality of wrapping multiple elements, but for replacment and inserts the target remains only the first selection (as it was before).
We need to decide later on what to do about insertion/replacements

<video src="https://github.com/concrete-utopia/utopia/assets/7003853/1825e5a1-b695-4c87-8bb1-89516728436c"></video>


**Manual Tests:**
I hereby swear that:

- [X] I opened a hydrogen project and it loaded
- [X] I could navigate to various routes in Preview mode

Fixes #5696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liady liady

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Wrap multiple elements using the new picker concrete-utopia/utopia
1 participant
@liady