From 6921162cb03dd03f5dbb64567015e2fe5c04ce94 Mon Sep 17 00:00:00 2001 From: Rui Yang Date: Tue, 29 Nov 2022 02:09:04 -0500 Subject: [PATCH] fix across step states bug it was showing state cancelling when sub steps are all succeeded Signed-off-by: Rui Yang --- web/elm/src/Build/StepTree/Models.elm | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/web/elm/src/Build/StepTree/Models.elm b/web/elm/src/Build/StepTree/Models.elm index c884ce25abe..13648f2e69a 100644 --- a/web/elm/src/Build/StepTree/Models.elm +++ b/web/elm/src/Build/StepTree/Models.elm @@ -157,12 +157,16 @@ mostSevereStepState model stepTree = activeTreeSteps model stepTree |> List.foldl (\step state -> - case stepStateOrdering step.state state of - LT -> - step.state - - _ -> + case step.buildStep of + Concourse.BuildStepDo _ -> state + _ -> + case stepStateOrdering step.state state of + LT -> + step.state + + _ -> + state ) StepStateSucceeded