-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hooks does not like header_only=True and still looks for shared artifacts #462
Comments
This PR was correct AFAIK, the configure delete should not be required with |
IMHO, options which are not used at all should be removed in configure() not package_id(). When header_only=True, shared option doesn't make sense anymore, it has not effect and therefore should be removed in configure(). It's not like a convenient option which for example enable a verbose build or something like this, but lead to the same package artifacts, this option changes what happens during the build (but end result is the same). So for me no this PR was not correct by allowing illformed recipes. |
Hooks does not like
header_only=True
and still looks for shared artifactsLogs for packageID
5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9
:Originally posted by @conan-center-bot in conan-io/conan-center-index#14634 (comment)
The text was updated successfully, but these errors were encountered: