Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ feature request ]: Use rustls instead of openssl #409

Open
yonas opened this issue Mar 15, 2024 · 4 comments
Open

[ feature request ]: Use rustls instead of openssl #409

yonas opened this issue Mar 15, 2024 · 4 comments

Comments

@yonas
Copy link

yonas commented Mar 15, 2024

rustls offers better portability and ease of compiling.

@martintc
Copy link
Contributor

martintc commented Mar 15, 2024

We've been trying, but its been an issue of not our direct dependencies but our transitive dependencies. Crates we rely on that have not either converted over to using rustls or will not or can not. Or some that have technical issues or they are waiting on transitive dependencies. An example is, for git we use Rawkode's gitsync which uses git2, which doesn't (although it been awhile since I've checked) use rustls. For this case, we are waiting for gitoxide to offer what we need, but the last time I looked this past October, gitoxide was still a ways away in offering features we needed.

@yonas yonas changed the title Feature: Use rustls instead of openssl [ feature request ]: Use rustls instead of openssl Mar 16, 2024
@shawn111
Copy link
Contributor

@martintc Is it a good idea to make git related function as feature? Let the main part of comtrya can remove the dependencies of openssl

@martintc
Copy link
Contributor

That is one possibility. I can talk with the other maintainers about that. Another solution @rawkode has thrown out there is to scrub git sync and have comtrya pull a pre-compiled git binary and use that instead of a library that replicates the functions of git.

@yonas
Copy link
Author

yonas commented May 1, 2024

... have comtrya pull a pre-compiled git binary and use that instead of a library that replicates the functions of git.

I'm not a fan of having to pull dependencies off the Internet at runtime. Maybe you meant at compile-time. Even so, once git sync is removed, gitoxide can take care of everything comtrya needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants