Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup the UpdateStats window #2956

Open
Tracked by #3053
ValarDragon opened this issue Apr 30, 2024 · 1 comment
Open
Tracked by #3053

Speedup the UpdateStats window #2956

ValarDragon opened this issue Apr 30, 2024 · 1 comment
Labels
enhancement New feature or request needs-information Waiting for additional information or feedback needs-triage This issue/PR has not yet been triaged by the team. p2p

Comments

@ValarDragon
Copy link
Collaborator

ValarDragon commented Apr 30, 2024

Feature Request

Summary

Peer gossip does an exponential moving average for choosing what channels to gossip on. Its currently set to decrementing the tracker by 20% every 2 seconds.

Consensus on Osmosis in its entirety takes 1 second, and were at block time 3s, soon to be 2.5s. So I think this EMA is very misparameterized. Instead I suggest making the updateStats tracker happen every 500ms. This is done by changing this constant right here: https://github.com/cometbft/cometbft/blob/main/p2p/conn/connection.go#L34

I think we should observe network behavior to determine if we should adjust this further. I imagine this does need to get further fine-grained if we think EMA is the way to do channel selection.

@ValarDragon ValarDragon added enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. labels Apr 30, 2024
@cason
Copy link
Contributor

cason commented May 10, 2024

Can you rephrase the title of the issue? And also make it clearer the goal?

@cason cason added the p2p label May 10, 2024
@cason cason added the needs-information Waiting for additional information or feedback label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-information Waiting for additional information or feedback needs-triage This issue/PR has not yet been triaged by the team. p2p
Projects
None yet
Development

No branches or pull requests

2 participants