Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the Priority weight for Vote and BlockPart channels #2955

Open
ValarDragon opened this issue Apr 30, 2024 · 0 comments
Open

Increase the Priority weight for Vote and BlockPart channels #2955

ValarDragon opened this issue Apr 30, 2024 · 0 comments
Labels
enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team.

Comments

@ValarDragon
Copy link
Collaborator

ValarDragon commented Apr 30, 2024

Feature Request

Summary

We should increase the priority weight for Vote and BlockPart channels, to ensure these packets at consensus time get prioritized over mempool tx gossip.

Right now the priorities are:

  • Vote: 7
  • Data: 10 (Aka Blockpart)
  • Mempool: 5

I suggest starting such a move by making it Vote: 40, and Data: 30. Assuming #2954 , Vote should likely be higher due to having two rounds of voting, vs data gossips one round per block, and much smaller number of block parts.

This unfortunately would increase the prioritization of catching up peers who are behind, until that is split out of the Data channel. I think thats worthwhile for increasing prioritization of consensus messages relative to the mempool

@ValarDragon ValarDragon added enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team.
Projects
None yet
Development

No branches or pull requests

1 participant