Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ScalaJS support #189

Open
DamianReeves opened this issue Jul 11, 2023 · 4 comments
Open

Include ScalaJS support #189

DamianReeves opened this issue Jul 11, 2023 · 4 comments

Comments

@DamianReeves
Copy link

So os-lib has always been cool, but now that it is a member of the Scala toolkit, the fact that the library doesn't support ScalaJS seems like a wart. It would be great of ScalaJS support could be added.

And yes, I know that many file and process things won't work in the browser but NodeJS and deno are out there.

@lefou
Copy link
Member

lefou commented Jul 11, 2023

Yeah. Scala.js support would be great. We gladly accept pull requests adding it.

@DamianReeves
Copy link
Author

Yeah. Scala.js support would be great. We gladly accept pull requests adding it.

Is there a willingness to accept multiple PRs for this effort?

I would imagine, some parts may be fairly straightforward (i.e. Path related operations) and some others requiring different levels of effort.
In my mind I see 3 main themes here: path, file I/O, and process support.

@SethTisue
Copy link
Contributor

Is there a willingness to accept multiple PRs for this effort?

I hope so (commenting as an observer not participant) — as long as the first PR merged adds a Scala.js section to the documentation that's clear about what works or doesn't.

@lefou
Copy link
Member

lefou commented Jul 12, 2023

Yeah. Scala.js support would be great. We gladly accept pull requests adding it.

Is there a willingness to accept multiple PRs for this effort?

Of course. I thought, I said exactly that in the above quote.

I would imagine, some parts may be fairly straightforward (i.e. Path related operations) and some others requiring different levels of effort. In my mind I see 3 main themes here: path, file I/O, and process support.

That's fine as long as we document it. The PRs should be clear about their draft state, so that users know whether to expect stable or unstable Scala.JS API. Also some test coverage is required to maintain it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants