Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POSIX shell] Correct quoted strings nesting #65

Open
AnrDaemon opened this issue Feb 16, 2018 · 14 comments
Open

[POSIX shell] Correct quoted strings nesting #65

AnrDaemon opened this issue Feb 16, 2018 · 14 comments
Assignees
Labels

Comments

@AnrDaemon
Copy link
Contributor

Right now, POSIX shell scripts' highlighting is broken on constructs such as

_target="$( readlink -fe "$1" )"

In short, it does not pick $( ) capture correctly.
If anybody can provide with pointers about fixing it, I would gladly appreciate the help.

@ctapmex
Copy link
Member

ctapmex commented Feb 14, 2024

@ctapmex ctapmex closed this as completed Feb 14, 2024
@AnrDaemon
Copy link
Contributor Author

AnrDaemon commented Feb 15, 2024

The new types Shell Scripts (POSIX) and Shell Scripts (bash) do not color sources at all. Selecting the sh/ksh/bash script manually will enable coloring as always, but the reported issue remains.

@ctapmex ctapmex reopened this Feb 15, 2024
@chpock
Copy link
Contributor

chpock commented Feb 15, 2024

@AnrDaemon could you please provide an example of shell script that is not highlighted?

@AnrDaemon
Copy link
Contributor Author

#!/bin/sh
true

@AnrDaemon
Copy link
Contributor Author

ping?

@ctapmex
Copy link
Member

ctapmex commented Apr 30, 2024

check latest version.
image

if something doesn't work yet, then an example is needed.

@AnrDaemon
Copy link
Contributor Author

At this point, the best I can do is to zip an entire base directory.
base-2024-05-01.zip

@ctapmex
Copy link
Member

ctapmex commented May 1, 2024

Sorry, I didn't understand the last one. This is your set of schemes, and? Yes, it's old, with something homemade. What should we understand from this?

@AnrDaemon
Copy link
Contributor Author

It's last released schemes with minimal custom additions. All changes are in "auto" directory. But removing them makes no change. Any idea what could be the cause?

@AnrDaemon
Copy link
Contributor Author

Another bit of information I just noticed:

  1. Open the .sh/.bash/wtf file.
  2. Manually(!) change the coloring scheme to something inapproprite. (Regedit, XML, whatever.) Entire file turns red.
  3. Change the scheme back to Shell (POSIX). Coloring do not change, the file's still red.
  4. Change the scheme to Shell (bash). Coloring disappears.

This makes me think the issue is somewhere inside the "Shell (POSIX)" theme, as "Shell (bash)" inherit from it.

@ctapmex
Copy link
Member

ctapmex commented May 2, 2024

which version of far and far colorer is used? the described behavior depends only on them. The schemes have nothing to do with it.

@AnrDaemon
Copy link
Contributor Author

Far 2.0.0.1807
FarColorer 1.0.3.7

@ctapmex
Copy link
Member

ctapmex commented May 3, 2024

Oh, this is a very old version. I find it difficult to say how it works. But according to your description, there are problems with redrawing after selecting a new file type. moving the cursor should help, as an option.

@AnrDaemon
Copy link
Contributor Author

Then my guess is that the new scheme uses something older Colorer do not understand. I'll have to dig out, what is it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants