Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests using leaflet mock #6

Open
colbyfayock opened this issue Oct 13, 2019 · 7 comments
Open

Create tests using leaflet mock #6

colbyfayock opened this issue Oct 13, 2019 · 7 comments
Assignees
Labels
Hacktoberfest help wanted Extra attention is needed

Comments

@colbyfayock
Copy link
Owner

Create some tests using the Leaflet mock under tests/__mocks__.

Particularly, can start with mocking out a map and testing functionality for promiseToZoomIn available in lib/map.

@colbyfayock colbyfayock added Hacktoberfest help wanted Extra attention is needed labels Oct 13, 2019
@RonnyNovik
Copy link

Could be a nice way to brush up my testing skills, i'll give it a try :)

@colbyfayock
Copy link
Owner Author

sounds great!

@RonnyNovik
Copy link

Unfortunately i cannot see the promiseToZoomIn func under lib/map.js, is it not merged to master yet?

@colbyfayock
Copy link
Owner Author

sorry about that! that must have changed since this isssue was created

want to do promiseToFlyTo?

export function promiseToFlyTo(map, { zoom, center }) {

@RonnyNovik
Copy link

Sure :)

@RonnyNovik
Copy link

I already see that you have a unit test for this functionality in map.test.js, are you sure you also need a cypress test for that?

@colbyfayock
Copy link
Owner Author

if you think we're comfortably covered then we can close this out @RonnyNovik

apologies if thats the case, this Issue must just be stale then

happy to accept any other coverage if you find any thats needed between Jest and Cypress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants