Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: use gap characters in <seqs>.get_identical_seqs() #1790

Open
GavinHuttley opened this issue Mar 25, 2024 · 0 comments
Open

ENH: use gap characters in <seqs>.get_identical_seqs() #1790

GavinHuttley opened this issue Mar 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@GavinHuttley
Copy link
Collaborator

The SequenceCollection.get_identical_sets() (and AlignmentI.get_identical_sets()) methods do not account for gaps, i.e. "ACG-" and "ACGT" are considered distinct. Add a "mask_gap" argument to the methods for both classes.

Should also split the methods into two private sub-methods that handle whether either mask_degen or mask_gap are set.

@GavinHuttley GavinHuttley added the enhancement New feature or request label Mar 25, 2024
@GavinHuttley GavinHuttley added this to the 2024 Q2 release milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant