feature/issue 1731 #1753
feature/issue 1731 #1753
Conversation
cogent3#1731 In this commit, the binomial_exact() function was removed and the related test_binomial_series(), test_binomial_exact(), test_binomial_exact_floats(), and test_binomial_exact_errors() were also been removed
There was a problem hiding this comment.
Thanks for the contribution!
When marking a function to be discontinued we limit our changes to applying the decorator and giving the reason (including referring users to a replacement in another project). In other words, we do not actually change our code within the function since we are going to be deleting it.
cogent3#1731 In this new commit, we revert the change within the function to the original, and delete the new import
In this issue, the version information in the decorator was changed from the wrong "2024.6" to "2024.9". The format was also changed to the correct form.
In this commit, linting was performed to correct the argument format.
In this commit, the "pragma: no cover" comment was added ,and the docstring within the function was changed to """being removed"""
|
Now I revert the change within the function to the original and delete the new imports. Please have a look : ) |
Pull Request Test Coverage Report for Build 8259402581Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
I have already made those required changes 2 weeks ago. Please have a look : ) |
There was a problem hiding this comment.
Thanks for your effort, but I can't accept this PR as is.
First, the replacement function in scipy you have identified is incorrect. It should be scipy.stats.binomtest. This means you would need to update your deprecation reason and, in doing so, correct the spacing between words.
Second, you would need to identify all uses of binomial_exact() in cogent3 and replace them with correct usage of the scipy function.
Finally, be sure and delete imports of binomial_exact() since it is no longer being used.
|
Closing due to lack of response to review. But thanks for your effort! |
DEP: remove the binomial_exact() function and the related tests , fixes #1731
Remove the
cogent3.maths.stats.binomial_exact()function, and removed the relatedtest_binomial_series(),test_binomial_exact(),test_binomial_exact_floats(), andtest_binomial_exact_errors()