Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust 'New feedbacks are not shown in reason popup when there are too many feedbacks' #556

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

marcussfu
Copy link
Contributor

截圖 2024-01-06 下午4 03 52

adjust limit to 1000, and hide feedbacks that no comment.

@coveralls
Copy link

coveralls commented Jan 6, 2024

Coverage Status

coverage: 71.246% (-4.9%) from 76.166%
when pulling 941b1ed on marcussfu:master
into 00dcd7a on cofacts:master.

Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into the issue!

Back in the hackathon I thought hiding feedbacks without comments may help us focusing on those with comments. However, it comes to my mind that showing feedbacks without comment can help the audience in:

  1. determine where the votes are from -- from other fact checkers, or from LINE users
  2. better spot coordinated inauthentic behavior, when a group of fake accounts upvote each other and downvote other legitimate replies.

Therefore, I think we should not filter out all those feedbacks that have no comments.

Instead, we can:

  • Show those with comments first
  • Then show comments without comments
  • If there are more than 10 comments, put a "show all" link at the bottom of the list. Clicking them can show all the rest of the comments.

@marcussfu would you mind making the change?

@marcussfu
Copy link
Contributor Author

ok, I'll change it.

@marcussfu
Copy link
Contributor Author

Alread modified, check please.

Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well, thank you for the change!

@MrOrz MrOrz merged commit 891a4fb into cofacts:master Feb 29, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New feedbacks are not shown in reason popup when there are too many feedbacks
3 participants