Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for context, plus code address #77

Open
mariotoffia opened this issue Nov 3, 2023 · 1 comment
Open

Support for context, plus code address #77

mariotoffia opened this issue Nov 3, 2023 · 1 comment

Comments

@mariotoffia
Copy link

Hi and thanks for a nice framework. I've forked it and did a minor update to at least return city, country (and added GlobalCode) in google lookups.

Also added context to the api calls since I use those in lambdas and need to cancel when lambda timeout. I also need the context in the logger (extracts certain values from context when logging).

I've done this in the following fork: https://github.com/mariotoffia/geo-golang - if it is ok - I can create a pr (of which I revert back my renaming of package to yours).

Again, many thanks!

Cheers,
Mario :)

@codingsince1985
Copy link
Owner

yes please @mariotoffia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants